[Ldap] fail if whoami() is called before saslBind()
#58144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 2, 2024
| Q | A |
|---|---|
| Branch? | 7.2 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
xabbuh
commented
Sep 2, 2024
|
|
||
| if (!@ldap_start_tls($h)) { | ||
| ldap_unbind($h); | ||
| $this->markTestSkipped('Cannot establish an encrypted connection'); |
There was a problem hiding this comment.
Investigating the failing integration test I found that SASL bind cannot be used when not having a secure connection. Since I didn't find a way to let our LDAP server used in the test have a proper TLS configuration I suggest that we skip tests in those cases.
There was a problem hiding this comment.
Spent an hour investigating on this and I have the same conclusion. I tried a few things to enable TLS with bitnami/openldap but it would require additional work, more than just turning TLS switch to "on" it seems.
whoami() is called before saslBind()
|
friendly ping @manu0401 as you contributed it in |
fabpot
approved these changes
Sep 6, 2024
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.