[Filesystem] Add a warning about chown() and chgrp() on Windows
#58153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fb1a7d7 to
4287d76
Compare
OskarStark
reviewed
Sep 3, 2024
OskarStark
reviewed
Sep 3, 2024
OskarStark
reviewed
Sep 3, 2024
OskarStark
reviewed
Sep 3, 2024
4287d76 to
43a055b
Compare
|
On Windows, they will throw an exception, isn't it? I'd rather keep these as is if yes. Maybe they can be supported in the future. |
2d79584 to
8342225
Compare
|
Alright. I propose to still add the comment with the link to PHP doc. I think it is always nice for the DX to have this kind of info next to the method. |
chown() and chgrp() on Windows8342225 to
c19daed
Compare
chown() and chgrp() on Windows
mtarld
approved these changes
Sep 9, 2024
mtarld
approved these changes
Sep 9, 2024
c19daed to
fa3fd9d
Compare
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chmod()andchgrp()are not supported on Windows (see this and this). I propose to skip the logic of these methods when running on Windows.