[Dotenv] [DebugCommang] Ensure console commands respect dotenv_path
#58159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setting from composer.json
dotenv_pathdotenv_path
dotenv_pathdotenv_path
xabbuh
reviewed
Sep 4, 2024
|
Can we add a test for it? |
xabbuh
reviewed
Sep 6, 2024
|
|
||
| $output = $this->executeCommand($projectDirectory, 'dev', 'config/.env'); | ||
|
|
||
| @unlink($projectDirectory.'/composer.json'); |
There was a problem hiding this comment.
Why is this necessary? Why don't we store the composer.json file in the fixtures directory in the repo?
There was a problem hiding this comment.
I did it before, but some tests failed for some reason. Please look at the previous commmit.
|
This concern was solved in #52638 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: ensure console commands respect
dotenv_pathsetting from composer.jsondotenv:dumpcommand for determiningdotenv_path.