-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Cache] Fix compatibility with Redis 6.1.0 pre-releases #58169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Version 6.1.0 hasn't been released yet, which basically means that the maintainers could decide to release an RC2 which will again break the logic that you're proposing. Is that correct? In that case, I wouldn't do anything here. The problem will resolve itself with the next release of ext-redis. |
An RC2 would still use the new signature. Comparing the version with
|
Oh right. I misunderstood your initial message. LGTM then. |
It was not really clear. My bad. |
I pushed a new commit as the signature was not correct. I had the following error: After applying the patch, this error is gone. |
Thank you @cedric-anne. |
The solution provided in #57885 will fix the compatibility with the PHPRedis 6.1.0 release, but the issue persists on the pre-releases (for instance the 6.1.0RC1 version).
I propose to use the new signatures for any 6.1.0 version, including its pre-releases.