Skip to content

[HttpFoundation] Update links for X-Accel-Redirect and fail properly when X-Accel-Mapping is missing #58181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

The current link is dead and the failure is currently a notice. Let's make this fail properly instead. /cc @dunglas ;)

@carsonbot carsonbot added this to the 5.4 milestone Sep 5, 2024
@OskarStark OskarStark changed the title [HttpFoundation] Update links for X-Accel-Redirect and fail properly when X-Accel-Mapping is missing [HttpFoundation] Update links for X-Accel-Redirect and fail properly when X-Accel-Mapping is missing Sep 5, 2024
@fabpot
Copy link
Member

fabpot commented Sep 13, 2024

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 463fdfd into symfony:5.4 Sep 13, 2024
12 checks passed
This was referenced Sep 21, 2024
@nicolas-grekas nicolas-grekas deleted the x-accel branch October 24, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants