Skip to content

[FrameworkBundle] Add --resolve-env-vars option to lint:container command #58199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

[FrameworkBundle] Add --resolve-env-vars option to lint:container command #58199

merged 1 commit into from
Sep 16, 2024

Conversation

ostrolucky
Copy link
Contributor

@ostrolucky ostrolucky commented Sep 7, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #58105
License MIT

@carsonbot carsonbot added this to the 7.2 milestone Sep 7, 2024
@ostrolucky ostrolucky changed the title [FrameworkBundle] Add --resolve-env-vars option to lint:container com… [FrameworkBundle] Add --resolve-env-vars option to lint:container command Sep 9, 2024
@OskarStark OskarStark changed the title [FrameworkBundle] Add --resolve-env-vars option to lint:container command [FrameworkBundle] Add --resolve-env-vars option to lint:container command Sep 10, 2024
nicolas-grekas
nicolas-grekas approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some minor CS changes (suggestions partly reverted).

@nicolas-grekas
Copy link
Member

Isn't the failure related?

@ostrolucky
Copy link
Contributor Author

Looks it got resolved with rebase :)

@nicolas-grekas
Copy link
Member

Thank you @ostrolucky.

@nicolas-grekas nicolas-grekas merged commit 13fd149 into symfony:7.2 Sep 16, 2024
9 of 10 checks passed
@nicolas-grekas nicolas-grekas mentioned this pull request Sep 16, 2024
Closed
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
@GromNaN GromNaN mentioned this pull request Nov 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

[FrameworkBundle] lint:container should check if referenced env variables exist
3 participants
@ostrolucky @nicolas-grekas @carsonbot