[Serializer][Uid][Validator] Mention RFC 9562 #58238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Sep 11, 2024
| @@ -24,7 +24,7 @@ final class UidNormalizer implements NormalizerInterface, DenormalizerInterface, | |||
| public const NORMALIZATION_FORMAT_CANONICAL = 'canonical'; | |||
| public const NORMALIZATION_FORMAT_BASE58 = 'base58'; | |||
| public const NORMALIZATION_FORMAT_BASE32 = 'base32'; | |||
| public const NORMALIZATION_FORMAT_RFC4122 = 'rfc4122'; | |||
| public const NORMALIZATION_FORMAT_RFC4122 = 'rfc4122'; // RFC 9562 obsoleted RFC 4122 but the format is the same | |||
There was a problem hiding this comment.
We might add public const NORMALIZATION_FORMAT_RFC9562 = self::NORMALIZATION_FORMAT_RFC4122; in Symfony 7.2 in case some people look for the format for RFC 9562.
stof
approved these changes
Sep 11, 2024
dunglas
approved these changes
Sep 12, 2024
derrabus
approved these changes
Sep 14, 2024
xabbuh
approved these changes
Sep 15, 2024
nicolas-grekas
added a commit
that referenced
this pull request
Sep 16, 2024
…`UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants (alexandre-daubois) This PR was merged into the 7.2 branch. Discussion ---------- [Serializer][Uid] Add the `Uuid::FORMAT_RFC_9562` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Following #58238 (cc `@fancyweb`), for completeness of this 7.2 feature. Commits ------- f84170a [Serializer][Uid] Add the `Uuid::FORMAT_RFC_9562` and `UidNormalizer::NORMALIZATION_FORMAT_RFC9562` constants
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Sep 21, 2024
This PR was merged into the 6.4 branch. Discussion ---------- [Routing][Uid] [6.4] Mention RFC 9562 | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Follow-up to #58238 on 6.4 Commits ------- edf9916 [6.4][Routing][Uid] Mention RFC 9562
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 4122 has been obsoleted by RFC 9562 since May 2024.
The format remains the same so we don't need to do anything. Renaming everything with BC would certainly be a waste of time. However, we can add some comments and update the links to be up-to-date.