[Notifier][TurboSMS] Process partial accepted response from transport #58242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Sep 12, 2024
OskarStark
approved these changes
Sep 12, 2024
8096577 to
932dbe3
Compare
|
Thank you @ZhukV. |
fabpot
added a commit
that referenced
this pull request
Sep 18, 2024
This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Notifier] [TurboSms] Better tests | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Follows #58242 | License | MIT Still waiting for #58242 to get unmerged, to fix also the newly introduced test. Commits ------- 553951e [Notifier] [TurboSms] Better tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TurboSMS can return
nullas message id, if sms not sent to recipient. Example:{ "response_code": 802, "response_status": "SUCCESS_MESSAGE_PARTIAL_ACCEPTED", "response_result": [ { "phone": "recipient_1", "response_code": 406, "message_id": null, "response_status": "NOT_ALLOWED_RECIPIENT_COUNTRY" }, { "phone": "recipient_2", "response_code": 0, "message_id": "f83f8868-5e46-c6cf-e4fb-615e5a293754", "response_status": "OK" } ] }And we receive error:
Symfony use only one phone number for sent, as result we check only first
response_result.