[Yaml] Add support for dumping null as an empty value by using the Yaml::DUMP_NULL_AS_EMPTY flag
#58243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
requested changes
Sep 12, 2024
|
The name of the constant makes me think that we stills should improve the parser to try to support all possible inline notations. Do you have a list of examples that would currently not be parsed properly? |
|
@xabbuh by taking into account the cases we don't want to support as listed by @stof in #58232 (comment), I would say that the only unsupported feature we may want to add support to is empty values in sequences, i.e. |
|
see #58279 |
6764111 to
0e0246b
Compare
null as an empty string by using the Yaml::DUMP_NULL_AS_EMPTY_IN_EXPANDED_NOTATION flagnull as an empty value by using the Yaml::DUMP_NULL_AS_EMPTY flag
|
I just pushed a new approach that takes into account @xabbuh's PR on supporting empty values in sequences. |
0e0246b to
f8d019a
Compare
xabbuh
reviewed
Sep 18, 2024
60c09d3 to
6d7e910
Compare
|
Status: Needs review |
6d7e910 to
ece1285
Compare
ece1285 to
a7d3a34
Compare
xabbuh
reviewed
Oct 13, 2024
xabbuh
approved these changes
Oct 15, 2024
…`Yaml::DUMP_NULL_AS_EMPTY` flag
a7d3a34 to
1fc1379
Compare
|
Thank you @alexandre-daubois. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another try after #58232. I went for the second solution from @stof (#58232 (comment)), namely dumping empty value as null just in expanded sequences and mappings. When the inline limit of the dumper is reached, it fallbacks on using
null(examples in tests).I'm not 100% happy about the name of the constant,
DUMP_NULL_AS_EMPTY_IN_EXPANDED_NOTATION. It's verbose. I'm open to suggestions!