Skip to content

[VarDumper] Fix dumping ext-dom virtual properties #58245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

[VarDumper] Fix dumping ext-dom virtual properties #58245

merged 1 commit into from
Sep 16, 2024

Conversation

alexandre-daubois
Copy link
Member

Q A
Branch? 7.2
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

Fixes PHP 8.4 CI job.

@carsonbot carsonbot added this to the 7.2 milestone Sep 12, 2024
@OskarStark OskarStark changed the title [VarDumper] Fix dumping ext-dom virtual properties [VarDumper] Fix dumping ext-dom virtual properties Sep 12, 2024
@alexandre-daubois alexandre-daubois force-pushed the dump-xml-fix branch 2 times, most recently from 5458b74 to e84fe39 Compare September 16, 2024 11:59
@xabbuh
Copy link
Member

xabbuh commented Sep 16, 2024

Thank you @alexandre-daubois.

@xabbuh xabbuh merged commit 0ce31a5 into symfony:7.2 Sep 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed VarDumper
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-daubois @xabbuh @OskarStark @carsonbot