[FrameworkBundle] Finish incomplete tests for lock & semaphore config #58250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c1124d4 to
0574c86
Compare
|
Thank you @HypeMC. |
fabpot
added a commit
that referenced
this pull request
Sep 18, 2024
…as lock/semaphore resource (HypeMC) This PR was merged into the 7.2 branch. Discussion ---------- [FrameworkBundle] Add ability to use existing service as lock/semaphore resource | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT Contains #58250 Currently, it's not possible to set an existing service as the lock/semaphore resource via the config, even though both factories support this functionality, eg: https://github.com/symfony/symfony/blob/44395abfcb2c859b26e0c6880c74dadd94da1038/src/Symfony/Component/Lock/Store/StoreFactory.php#L27-L36 Commits ------- 670ee5d [FrameworkBundle] Add ability to use existing service as lock/semaphore resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working on #58249. Basically, the test files were partially added but never used, so the tests were incomplete.
Also, there's a bug in the schema, as the configuration in those files didn't work.