Skip to content

[TypeInfo] Return bound type as base type in TemplateType #58259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2024
Merged

[TypeInfo] Return bound type as base type in TemplateType #58259

merged 1 commit into from
Sep 18, 2024

Conversation

valtzu
Copy link
Contributor

@valtzu valtzu commented Sep 13, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58031
License MIT

This supersedes #58033 as simpler approach.

@valtzu valtzu requested a review from dunglas as a code owner September 13, 2024 16:13
@carsonbot carsonbot added this to the 7.2 milestone Sep 13, 2024
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.2" but it seems your PR description refers to branch "7.1".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@valtzu valtzu changed the base branch from 7.2 to 7.1 September 13, 2024 16:13
@valtzu valtzu mentioned this pull request Sep 13, 2024
Closed
mtarld
mtarld reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@mtarld mtarld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@valtzu valtzu force-pushed the serializer-generics-template-fix-v2 branch from 8d50547 to f897a7b Compare September 16, 2024 16:19
@fabpot fabpot modified the milestones: 7.2, 7.1 Sep 18, 2024
@fabpot
Copy link
Member

fabpot commented Sep 18, 2024

Thank you @valtzu.

@fabpot fabpot merged commit bd3a256 into symfony:7.1 Sep 18, 2024
8 of 10 checks passed
@fabpot fabpot mentioned this pull request Sep 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@mtarld mtarld mtarld approved these changes

@chalasr chalasr chalasr approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Status: Reviewed TypeInfo
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.

Exception deserializing class with generic property
5 participants
@valtzu @carsonbot @fabpot @mtarld @chalasr