[Notifier] [TurboSms] Better tests #58280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
commented
Sep 16, 2024
| @@ -128,10 +109,8 @@ public function testInvalidFrom() | |||
| $this->expectException(LengthException::class); | |||
| $this->expectExceptionMessage('The sender length of a TurboSMS message must not exceed 20 characters.'); | |||
|
|
|||
| $message = new SmsMessage('380931234567', 'Hello!'); | |||
| $transport = new TurboSmsTransport('authToken', 'abcdefghijklmnopqrstu', $this->createMock(HttpClientInterface::class)); | |||
| new TurboSmsTransport('authToken', 'abcdefghijklmnopqrstu', $this->createMock(HttpClientInterface::class)); | |||
There was a problem hiding this comment.
the exception happens already in TurboSmsTransport::constructor(), no need to call send()
b8b93fa to
b19feec
Compare
|
Rebased and ready to merge from my side |
alexandre-daubois
approved these changes
Sep 18, 2024
xabbuh
reviewed
Sep 18, 2024
src/Symfony/Component/Notifier/Bridge/TurboSms/Tests/TurboSmsTransportTest.php
Outdated
Show resolved
Hide resolved
OskarStark
commented
Sep 18, 2024
src/Symfony/Component/Notifier/Bridge/TurboSms/Tests/TurboSmsTransportTest.php
Outdated
Show resolved
Hide resolved
xabbuh
approved these changes
Sep 18, 2024
86cb707 to
553951e
Compare
|
Thank you @OskarStark. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still waiting for #58242 to get unmerged, to fix also the newly introduced test.