[HttpKernel] Skip logging uncaught exceptions in ErrorHandler
, assume $kernel->terminateWithException()
will do it
#58289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uncaught exceptions are handled by
ErrorHandler::handleException()
, that method logs them, then calls a callback to let the app know about the exception itself.This causes two issues:
excluded_http_codes
not working as intended for http errors thrown inside the callback of a StreamedResponse #57902In this PR, I propose to consider that if terminateWithException is configured as a callback, we assume that the app will handle the logging on its own.
Tested in practice, this works nicely.
Adding a test case is quite complex as all this involves many pieces and global state, so I skipped adding one.