[DependencyInjection] Fix XmlFileLoader not respecting when env for services
#58299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/DependencyInjection/Tests/Fixtures/RemoteCallerHttp.php
Outdated
Show resolved
Hide resolved
4c4e3bf to
2ec78d9
Compare
|
Small bump to check if there is anything additional required from my side. |
nicolas-grekas
approved these changes
Sep 27, 2024
XmlFileLoader not respecting when env for…XmlFileLoader not respecting when env for services
|
Thank you @CipherdevNL. |
This was referenced Oct 27, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug inside the
XmlFileLoaderthat causes the loading of all services inside a<when env="..." />elements even when not in the defined environment.My knowledge about xPath is very limited, but it seems like the parser interpets
.//as//(anywhere) while most like./(relative) was meant, due to the passing of an$rootelement. Based on the added test and passing of existing test this change seems like sufficient to respect the<when env="...." />