[Serializer] Re-add AdvancedNameConverterInterface
#58307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f875bdb to
7d989bc
Compare
7d989bc to
222fb4c
Compare
AdvancedNameConverterInterface as deprecatedAdvancedNameConverterInterface
stof
reviewed
Sep 18, 2024
| @@ -19,7 +19,7 @@ | |||
| * @author Kévin Dunglas <dunglas@gmail.com> | |||
| * @author Aurélien Pillevesse <aurelienpillevesse@hotmail.fr> | |||
| */ | |||
| class CamelCaseToSnakeCaseNameConverter implements NameConverterInterface | |||
| class CamelCaseToSnakeCaseNameConverter implements NameConverterInterface, AdvancedNameConverterInterface | |||
There was a problem hiding this comment.
CamelCaseToSnakeCaseNameConverter was not an advanced converter in 7.0 so there is nothing to re-add there, and adding the arguments in the signature natively is a BC break for child classes.
There was a problem hiding this comment.
Indeed, you're right, plus I didn't get all the history of that PR (#53898 (comment)).
I'm going to close that PR, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-add
AdvancedNameConverterInterfaceon top ofCamelCaseToSnakeCaseNameConverterandMetadataAwareNameConverter.