You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What I mean is that the operator regex must be used at one point to parse operators. If that regex wasn’t correct before, we need to find an expression that was not parsed properly and use that to build a test.
What I mean is that the operator regex must be used at one point to parse operators. If that regex wasn’t correct before, we need to find an expression that was not parsed properly and use that to build a test.
@xabbuh It's not that the regex wasn't correct in the sense that it didn't work. There are tests that cover the functionality, and they passed. It's just that the regex generated by the script has a slightly different order and uses preg_quote, which escapes some additional characters.
…rator (HypeMC)
This PR was merged into the 7.2 branch.
Discussion
----------
[ExpressionLanguage] Add support for logical `xor` operator
| Q | A
| ------------- | ---
| Branch? | 7.2
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Issues | -
| License | MIT
Contains #58342
Adds support for the logical `xor` operator.
Commits
-------
6e0a613 [ExpressionLanguage] Add support for logical `xor` operator
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes/uses the
generate_operator_regex.phpscript for the regex added in #58052