[HttpKernel] Improve accessibility #58366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this flagged as |
|
@stof you are right. I fixed it. |
yceruto
approved these changes
Sep 23, 2024
This was referenced Sep 24, 2024
fabpot
added a commit
that referenced
this pull request
Sep 27, 2024
…panel (javiereguiluz) This PR was merged into the 7.2 branch. Discussion ---------- [WebProfilerBundle] Update the contents of the Config panel | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | -lain below instead --> | License | MIT Similar to #58366 and #58380, this fixes an accessibility issue of the Web Debug Toolbar: ``` The "title" attribute can't be used in non-interactive elements ``` It now looks like this:  Commits ------- 9f8d2f9 [WebProfilerBundle] Update the contents of the Config panel
fabpot
approved these changes
Sep 27, 2024
4835666 to
3268842
Compare
|
Thank you @javiereguiluz. |
Merged
fabpot
added a commit
that referenced
this pull request
Mar 29, 2025
…e toolbar (javiereguiluz) This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [WebProfilerBundle] Update the logic that minimizes the toolbar | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | - | License | MIT While working on fixing the accessibility issues of the toolbar (see #58366) I saw the following error reported: ``` Accesskey "D" is used more than once ``` This prevents the feature from working properly. So, in this PR I changed everything about how the toolbar is minimized: * Remove the "mini toolbar" (which is the button displayed when the toolbar is minimized) * Remove the `.sf-toolbar-clearer` element which is no longer needed * Transform the "hide" button into a "toggle" button to show/hide the toolbar * Update the show/hied logic to use CSS classes instead of just `style: none/block` For end users nothing changes. It looks the same as before. #SymfonyHackday Commits ------- 06ed516 [WebProfilerBundle] Update the logic that minimizes the toolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are still some things to improve, but I'll do that in a separate PR because requires some changes.