Skip to content

[Translation] Allow sort when extracting translation files #58408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2024
Merged

[Translation] Allow sort when extracting translation files #58408

merged 1 commit into from
Oct 3, 2024

Conversation

danut007ro
Copy link
Contributor

@danut007ro danut007ro commented Sep 27, 2024 •
edited
Loading

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #49250 #37918
License MIT

This will keep current sorting when no --sort is specified.

  • when dumping messages will sort asc by default
  • when writing files will apply no sorting

@carsonbot carsonbot added this to the 6.4 milestone Sep 27, 2024
@OskarStark
Copy link
Contributor

Needs to be against 7.2 branch

@OskarStark OskarStark modified the milestones: 6.4, 7.2 Sep 27, 2024
@danut007ro danut007ro changed the base branch from 6.4 to 7.2 September 27, 2024 16:11
@danut007ro danut007ro changed the base branch from 7.2 to 6.4 September 27, 2024 16:11
@danut007ro danut007ro changed the base branch from 6.4 to 7.2 September 27, 2024 16:17
@danut007ro danut007ro force-pushed the translation-update-command-sort branch from 0578d08 to 0396299 Compare September 27, 2024 16:18
@danut007ro danut007ro force-pushed the translation-update-command-sort branch from 0396299 to e517ce9 Compare September 27, 2024 16:27
@nicolas-grekas
Copy link
Member

Thank you @danut007ro.

@nicolas-grekas nicolas-grekas merged commit 22213fc into symfony:7.2 Oct 3, 2024
5 of 10 checks passed
This was referenced Oct 3, 2024
Closed
Closed
Closed
@fabpot fabpot mentioned this pull request Oct 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof left review comments

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark approved these changes

@mtarld mtarld mtarld approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Feature Status: Reviewed Translation
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.

Sort flag in translation:extract command doesn't seem to work
6 participants
@danut007ro @OskarStark @nicolas-grekas @stof @mtarld @carsonbot