[Translation] Fix extracting of message from ->trans() method with named params #58409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
welcoMattic
approved these changes
Sep 27, 2024
smnandre
reviewed
Sep 28, 2024
| @@ -44,7 +44,7 @@ public function leaveNode(Node $node): ?Node | |||
| if ('trans' === $name || 't' === $name) { | |||
| $firstNamedArgumentIndex = $this->nodeFirstNamedArgumentIndex($node); | |||
|
|
|||
| if (!$messages = $this->getStringArguments($node, 0 < $firstNamedArgumentIndex ? 0 : 'message')) { | |||
| if (!$messages = $this->getStringArguments($node, 0 < $firstNamedArgumentIndex ? 0 : 'id')) { | |||
There was a problem hiding this comment.
Both the twig callables t and trans refer to the translator trans() method / t function, and all of them have '$message' as first attribute 🤷♂️
So i'm not sure to understand here (especially as you changed the MethodVisitor code and the test at the same time)
There was a problem hiding this comment.
You can try to inject TranslatorInterface to your service, call ->trans()
->trans('foo', domain: 'domain') this is extractable
->trans(id: 'foo', domain: 'domain') this is NOT extractable
xabbuh
approved these changes
Sep 28, 2024
|
Thank you @tugmaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes a problem of an extracting translations from
\Symfony\Contracts\Translation\TranslatorInterface::trans()methodAs you can see the first argument is named as
id, but notmessage, as expected in Visitor