[HttpFoundation] ensure session storages are opened in tests before destroying them #58453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 4, 2024
alexandre-daubois
approved these changes
Oct 4, 2024
|
Thank you @xabbuh. |
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Oct 10, 2024
The changes done in symfony#58453 were not enough. Since the session name is used as the cookie name it must not be the empty string.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Oct 10, 2024
The changes done in symfony#58453 were not enough. Since the session name is used as the cookie name it must not be the empty string.
xabbuh
added a commit
that referenced
this pull request
Oct 11, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [HttpFoundation] session names must not be empty | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT The changes done in #58453 were not enough. Since the session name is used as the cookie name it must not be the empty string. Commits ------- 4d595f4 session names must not be empty
symfonyaml
pushed a commit
to symfonyaml/symfony
that referenced
this pull request
Oct 21, 2024
The changes done in symfony#58453 were not enough. Since the session name is used as the cookie name it must not be the empty string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests currently only pass by luck as the condition in https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/HttpFoundation/Session/Storage/Handler/AbstractSessionHandler.php#L129 does not evaluate to
true(because headers are already sent).