Skip to content

[FrameworkBundle] Fix displayed stack trace when session is used on stateless routes #58459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues -
License MIT

It looks like we forgot to wire this in #36129
As a result, the stateless flag is hard to debug.
This wiring ensures we can display the offending stack trace instead of a clueless one thrown on kernel.response at the moment.

@nicolas-grekas nicolas-grekas changed the title [FrameworkBundle] Fix passing request_stack to session.listener [FrameworkBundle] Fix displayed stack trace when session is used on stateless routes Oct 4, 2024
@nicolas-grekas nicolas-grekas merged commit 2d324e5 into symfony:5.4 Oct 4, 2024
11 of 12 checks passed
@nicolas-grekas nicolas-grekas deleted the fwb-stateless-fix branch October 4, 2024 13:07
This was referenced Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants