-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Messenger] Extend SQS visibility timeout for messages that are still being processed #58483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9975ebe
to
cf58b19
Compare
OskarStark
reviewed
Oct 7, 2024
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Tests/Transport/AmazonSqsIntegrationTest.php
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Oct 9, 2024
valtzu
commented
Oct 9, 2024
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/Connection.php
Show resolved
Hide resolved
fabpot
added a commit
that referenced
this pull request
Oct 14, 2024
…ethods (valtzu) This PR was merged into the 7.2 branch. Discussion ---------- [Console][Messenger] Add `$seconds` to `keepalive()` methods | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | yes | Deprecations? | no | License | MIT Make the transport aware for how long (at minimum) the message should be kept alive. F.e. when extending SQS visibility timeout, you need to pass the visibility timeout (seconds) as parameter. If you pass a value which is less than alarm interval, SQS would resend the message too early. By making the transport aware of when the next keepalive call will happen we'll be able to do some assertions/clamping to improve DX. This is a prerequisite for #58483. Commits ------- e3beb18 Add `$seconds` to `keepalive` methods
4bbe383
to
41a94df
Compare
stof
reviewed
Oct 14, 2024
src/Symfony/Component/Messenger/Bridge/AmazonSqs/Transport/AmazonSqsTransport.php
Outdated
Show resolved
Hide resolved
41a94df
to
fa795c3
Compare
fabpot
approved these changes
Nov 9, 2024
Thank you @valtzu. |
This was referenced Nov 9, 2024
Open
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that #53508 is merged, let's add keepalive implementation for SQS too.