[MonologBridge] Fix PHP deprecation with preg_match()
#58492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simoheinonen
commented
Oct 8, 2024
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | |
| License | MIT |
stof
approved these changes
Oct 8, 2024
|
Can we add a test to prevent regressions? |
|
@xabbuh I don't think so, it is a language-level deprecation so I don't think we can really do anything here? |
|
you can write a test running that code without a User-Agent header (i.e. triggering the code path for which you solved the deprecation) |
preg_match()
ca9b0c1 to
4d7a6f6
Compare
|
Thank you @simoheinonen. |
fabpot
added a commit
that referenced
this pull request
Oct 13, 2024
This PR was merged into the 5.4 branch. Discussion ---------- [MonologBridge] simplify test | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT we can simplify the test added in #58492 by dropping the custom exception handler as a triggered deprecation would let the test fail anyway Commits ------- aa9eb60 simplify test
This was referenced Oct 27, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.