[Validator] Enhance PHPDoc on Constraint::getTargets()
#58493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b2b9050 to
987af2f
Compare
stof
approved these changes
Oct 8, 2024
xabbuh
approved these changes
Oct 8, 2024
| * Constraint::CLASS_CONSTRAINT and Constraint::PROPERTY_CONSTRAINT. | ||
| * | ||
| * @return string|string[] One or more constant values | ||
| * @return self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT|array<self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT> One or more constant values |
There was a problem hiding this comment.
wouldn't this work?
Suggested change
| * @return self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT|array<self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT> One or more constant values | |
| * @return self::*_CONSTRAINT|array<self::*_CONSTRAINT> One or more constant values |
There was a problem hiding this comment.
It works: https://phpstan.org/r/e511c5d3-eacc-4d1d-b9b3-c45683a3429f
I hesitated, because we could unintentionally include new constants ending with _CONSTRAINT. But if it seems OK to you, I'm fine with it 👍
There was a problem hiding this comment.
It appears to not work for Psalm (https://psalm.dev/r/25734b245c), which is a requirement for us (as this is what we use in our own CI).
There was a problem hiding this comment.
Oh right, let's keep it as-is then. Thanks!
There was a problem hiding this comment.
then:
Suggested change
| * @return self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT|array<self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT> One or more constant values | |
| * @return self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT|array<self::CLASS_CONSTRAINT|self::PROPERTY_CONSTRAINT> |
7f5ce66 to
bc81173
Compare
bc81173 to
5492bf4
Compare
|
Thank you @alexandre-daubois. |
xabbuh
added a commit
that referenced
this pull request
Oct 14, 2024
…return types (xabbuh) This PR was merged into the 7.2 branch. Discussion ---------- [ErrorHandler] resolve class constant types when patching return types | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | | License | MIT account for types like the ones added in #58493 Commits ------- 01eb32c resolve class constant types when patching return types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides better static analysis on constraints.