Skip to content

[JsonEncoder] Wire services #58515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Oct 9, 2024

Q A
Branch? 7.3
Bug fix? no
New feature? yes
Deprecations? no
Issues
License MIT

Follow-up of

The FrameworkBundle part of the JsonEncoder component introduction.

The component related config is quite simple:

framework:
    json_encoder:
        paths:
            App\EncodableDto\: '../src/EncodableDto/*'

Plus, the framework integration proposes the following bindings:

  • EncoderInterface $jsonEncoder to the json_encoder.encoder service
  • DecoderInterface $jsonDecoder to the json_encoder.decoder service

As this PR is based on top of #51718, only the last commit should be considered.

@carsonbot carsonbot added this to the 7.2 milestone Oct 9, 2024
@mtarld mtarld changed the title [JsonEncoder] Introduce component [FrameworkBundle] [JsonEncoder] Wire services Oct 9, 2024
@OskarStark OskarStark changed the title [FrameworkBundle] [JsonEncoder] Wire services [FrameworkBundle][JsonEncoder] Wire services Oct 9, 2024
@mtarld mtarld force-pushed the json-encoder-framework branch 2 times, most recently from d557b52 to f5cfb58 Compare October 15, 2024 15:35
@mtarld mtarld force-pushed the json-encoder-framework branch from f5cfb58 to 88a0fa8 Compare October 29, 2024 11:17
@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@mtarld mtarld force-pushed the json-encoder-framework branch 2 times, most recently from a619f6f to 16afac7 Compare December 3, 2024 17:44
@chalasr
Copy link
Member

chalasr commented Dec 10, 2024

@mtarld Can you please rebase this one?

@mtarld mtarld force-pushed the json-encoder-framework branch from 16afac7 to e213884 Compare December 10, 2024 21:06
@chalasr
Copy link
Member

chalasr commented Dec 11, 2024

Thank you @mtarld.

@carsonbot carsonbot changed the title [FrameworkBundle][JsonEncoder] Wire services [JsonEncoder] Wire services Dec 11, 2024
@chalasr chalasr merged commit 30d8c31 into symfony:7.3 Dec 11, 2024
8 of 11 checks passed
@chalasr
Copy link
Member

chalasr commented Dec 11, 2024

Please don't forget to write some docs for this component. Thanks

@mtarld mtarld deleted the json-encoder-framework branch December 11, 2024 12:24
@fabpot fabpot mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants