Skip to content

[Notifier] silence warnings triggered when malformed XML is parsed #58525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Oct 10, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

The constructor of the SimpleXMLElement class issues a warning if the passed data is not valid.

The constructor of the SimpleXMLElement class issues a warning if the passed
data is not valid.
@stof
Copy link
Member

stof commented Oct 10, 2024

shouldn't a malformed XML be reported as a failure though ?

@xabbuh
Copy link
Member Author

xabbuh commented Oct 10, 2024

That's already the case (see the testThrowExceptionWhenMessageWasNotSent() test).

@xabbuh xabbuh merged commit a2991ca into symfony:6.4 Oct 17, 2024
9 of 10 checks passed
@xabbuh xabbuh deleted the kaz-info-teh-silence-warning branch October 17, 2024 06:25
This was referenced Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants