[HttpClient] Add total_time to the response log
#58555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
total_time to the response log.total_time to the response log
smoench
reviewed
Oct 14, 2024
src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php
Outdated
Show resolved
Hide resolved
OskarStark
reviewed
Oct 17, 2024
src/Symfony/Component/HttpClient/Response/TransportResponseTrait.php
Outdated
Show resolved
Hide resolved
chalasr
approved these changes
Oct 22, 2024
|
Thank you @jwage. |
f8ab2fc to
c8bfb79
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2024
…s-grekas) This PR was merged into the 7.2 branch. Discussion ---------- [HttpClient] Fix computing stats for PUSH with Amp | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | - | License | MIT Tests with PUSH/vulcain fail after #58555. Computing stats for PUSH could be backported to lower versions, but let's keep things simple and consider this as an improvement, so not for lower branches. Commits ------- 792b970 [HttpClient] Fix computing stats for PUSH with Amp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the response
total_timeto the info log.info()to pass context instead of using sprintf, that way I can parse out variables the logs more easily.