[Ldap] Deprecate the sizeLimit query option
#58558
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
880590f to
2ab94d5
Compare
OskarStark
approved these changes
Oct 14, 2024
xabbuh
reviewed
Oct 14, 2024
bca660d to
e946fdc
Compare
e946fdc to
ce66e4e
Compare
xabbuh
approved these changes
Oct 14, 2024
fabpot
approved these changes
Oct 18, 2024
|
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sizeLimitoption is never used, it is actually calculated with themaxItemsoption inQuery. I propose to deprecate the option that is currently no-op anyway.