[PhpUnitBridge] do not patch the TestCase class with PHPUnit 10+ #58571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it be possible to have a little description in the PR to understand why this change is required please? Would be useful if we need to come back to this someday 😄 |
41cf723 to
9aea66e
Compare
4bda026 to
370f45d
Compare
The PHPUnit\TextUI\Command class was removed in PHPUnit 10. Since the sole purpose of the class extended the base Command class is to register a the Symfony test listener we can completely stop patching it as support for the listener-based event system was also removed in PHPUnit 10.
370f45d to
eb42716
Compare
chalasr
approved these changes
Oct 22, 2024
| @@ -109,6 +109,11 @@ | |||
| $PHPUNIT_VERSION = $MAX_PHPUNIT_VERSION; | |||
| } | |||
|
|
|||
| if (version_compare($PHPUNIT_VERSION, '10.0', '>=') && version_compare($PHPUNIT_VERSION, '11.0', '<')) { | |||
| fwrite(STDERR, 'This script does not work with PHPUnit 10.'.\PHP_EOL); | |||
There was a problem hiding this comment.
Suggested change
| fwrite(STDERR, 'This script does not work with PHPUnit 10.'.\PHP_EOL); | |
| fwrite(STDERR, 'The simple-phpunit script does not work with PHPUnit 10.'.\PHP_EOL); |
There was a problem hiding this comment.
Not sure about this because when you install the bridge the recipe will create a bin/phpunit file which one will run. So no pointer about a simple-phpunit script. My guess was that this is also the reason why the check on line 16 also talks about "This script".
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHPUnit\TextUI\Command class was removed in PHPUnit 10. Since the sole purpose of the class extended the base Command class is to register a the Symfony test listener we can completely stop patching it as support for the listener-based event system was also removed in PHPUnit 10.