Skip to content

[Messenger] Allow auto creation of sqs queue #58575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: 7.4
Choose a base branch
from
Open

[Messenger] Allow auto creation of sqs queue #58575

wants to merge 2 commits into from
+10 −2

Conversation

kevinrudde
Copy link

Q A
Branch? 7.2
Bug fix? no
New feature? yes
Deprecations? no
Issues Fix #42208
License MIT

I had a look at #44021, which was closed. I implemented the proposed solution in this comment.

In the setup function, the code now validates whether the account ID of the current caller identity matches the account ID specified in the DSN. If the IDs match, the queue is created; otherwise, it is not.

@carsonbot carsonbot added this to the 7.2 milestone Oct 15, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@kevinrudde kevinrudde force-pushed the fix_42208 branch 3 times, most recently from 7d6f13b to 4314c00 Compare October 16, 2024 06:50
@kevinrudde
Copy link
Author

kevinrudde commented Oct 29, 2024 •
edited
Loading

Any chance this could land in 7.2?
It seems like the Unit Test is failing, because of some corrupted composer zip?
Edit: Got it working by rebasing!

@fabpot fabpot modified the milestones: 7.2, 7.3 Nov 20, 2024
@fabpot fabpot modified the milestones: 7.3, 7.4 May 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature Messenger Status: Needs Review
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

Messenger Amazon SQS Connection::setup() throws exception when needing to create a queue
3 participants
@kevinrudde @carsonbot @fabpot