-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Remove always true/false occurrences #58600
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nicolas-grekas
merged 1 commit into
symfony:7.2
from
alexandre-daubois:remove-always-true-false
Oct 23, 2024
Merged
Remove always true/false occurrences #58600
nicolas-grekas
merged 1 commit into
symfony:7.2
from
alexandre-daubois:remove-always-true-false
Oct 23, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50595e8
to
622f149
Compare
stof
reviewed
Oct 18, 2024
783878e
to
a1f101e
Compare
xabbuh
reviewed
Oct 21, 2024
...Bundle/SecurityBundle/DependencyInjection/Compiler/ReplaceDecoratedRememberMeHandlerPass.php
Show resolved
Hide resolved
xabbuh
reviewed
Oct 22, 2024
a1f101e
to
66809df
Compare
Thanks Wouter for reopening! @xabbuh, I addressed your comments |
xabbuh
approved these changes
Oct 22, 2024
66809df
to
6980384
Compare
Thank you @alexandre-daubois. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most occurrences are surely artifact of when PHP allowed less typing.