Skip to content

[Serializer] Add an option to the XmlEncoder allowing to decode tags as collection #58604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: 7.4
Choose a base branch
from
Open

[Serializer] Add an option to the XmlEncoder allowing to decode tags as collection #58604

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
f93c89a
feat(serializer): add option to force collection when decoding xml
AlexandreGerault Oct 19, 2024
46e9197
fix: ci and style
AlexandreGerault Oct 21, 2024
dff07d4
ci: fix suggestions by fabbot.io
AlexandreGerault Oct 21, 2024
58fc1a9
revert: remove false positive from fabbot.io
AlexandreGerault Oct 23, 2024
517cd87
refactor(serializer): remove named parameter
AlexandreGerault Oct 23, 2024
0921aae
feat(serializer): use default context when context does not supply op…
AlexandreGerault Oct 23, 2024
6f7d48f
feat(serializer): add FORCE_COLLECTION option to XmlEncoderContextBui…
AlexandreGerault Oct 30, 2024
61ee9c8
feat(serializer): add static analysis
AlexandreGerault Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor(serializer): remove named parameter
  • Loading branch information
@AlexandreGerault
AlexandreGerault committed Oct 23, 2024
commit 517cd8748c8879ce28d83f3f7b9e1098d663199d
2 changes: 1 addition & 1 deletion src/Symfony/Component/Serializer/Encoder/XmlEncoder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ private function parseXml(\DOMNode $node, array $context = []): array|string
if (\is_array($value)
&& ($childNodeName = $node->firstChild?->nodeName)
&& 1 === \count($value)
&& \in_array($nodeName, $context[self::FORCE_COLLECTION] ?? [], strict: true)
&& \in_array($nodeName, $context[self::FORCE_COLLECTION] ?? [], true)
) {
return [$childNodeName => [$value[$childNodeName]]];
}
Expand Down