[Intl] do not access typed property before initialization #58623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 22, 2024
| Q | A |
|---|---|
| Branch? | 6.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #58600 (comment) |
| License | MIT |
| @@ -72,12 +72,12 @@ public function createInverse(): self | |||
|
|
|||
| public function getErrorCode(): int|false | |||
| { | |||
| return $this->transliterator?->getErrorCode() ?? 0; | |||
| return isset($this->transliterator) ? $this->transliterator->getErrorCode() : 0; | |||
There was a problem hiding this comment.
Is this really needed? Do the tests fail without the patch? Doesn't the ?? already guard against these?
There was a problem hiding this comment.
The null-coalesce operator doesn't help here when calling a method (that's why this went unnoticed in the linked discussion). The tests are failing without these changes (see also https://3v4l.org/HBV0b).
nicolas-grekas
approved these changes
Oct 22, 2024
src/Symfony/Component/Intl/Transliterator/EmojiTransliterator.php
Outdated
Show resolved
Hide resolved
f2f7bdb to
3ca2927
Compare
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.