Skip to content

[SecurityBundle] Use Composer InstalledVersions to check if flex is installed #58643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2025
Merged

[SecurityBundle] Use Composer InstalledVersions to check if flex is installed #58643

merged 1 commit into from
May 10, 2025

Conversation

andyexeter
Copy link
Contributor

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58624
License MIT

As discussed in #58624, this fixes a class not found error which is thrown when security bundle config is missing.

@andyexeter andyexeter requested a review from chalasr as a code owner October 23, 2024 09:38
@carsonbot carsonbot added this to the 7.1 milestone Oct 23, 2024
@andyexeter
Copy link
Contributor Author

Appveyor build failure appears unrelated

@stof
Copy link
Member

stof commented Oct 23, 2024

In other places, we perform the class_exists check on the Recipe class of flex (which has no extra dependency through a parent class) to detect the fact that Flex is installed.

@andyexeter
Copy link
Contributor Author

In other places, we perform the class_exists check on the Recipe class of flex (which has no extra dependency through a parent class) to detect the fact that Flex is installed.

@stof could you point me in the direction of where that is done? I can't find any reference to the Recipe class in the Symfony monorepo.

@nicolas-grekas is anything blocking this being merged?

@nicolas-grekas nicolas-grekas modified the milestones: 7.1, 7.2 Feb 4, 2025
@OskarStark OskarStark changed the title [SecurityBundle] Use Composer InstalledVersions to check if flex is installed [SecurityBundle] Use Composer InstalledVersions to check if flex is installed Apr 9, 2025
@andyexeter andyexeter mentioned this pull request Apr 23, 2025
Closed
@fabpot fabpot changed the base branch from 7.1 to 7.2 May 10, 2025 09:56
@fabpot fabpot force-pushed the 58624-security-bundle-composer-installed-versions branch from 74a5f3d to 5f8eb21 Compare May 10, 2025 09:56
@fabpot
Copy link
Member

fabpot commented May 10, 2025

Thank you @andyexeter.

@fabpot fabpot merged commit d0ce2d6 into symfony:7.2 May 10, 2025
9 of 11 checks passed
@fabpot fabpot mentioned this pull request May 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@Spomky Spomky Spomky approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Bug SecurityBundle Status: Reviewed
Projects
None yet
Milestone
7.2
Development

Successfully merging this pull request may close these issues.
7 participants
@andyexeter @stof @fabpot @nicolas-grekas @OskarStark @Spomky @carsonbot