-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Mailer] Fix TypeError in on SMTP error #58650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Did you actually experience this error or is it reported by some static analysis tool? |
My colleague experienced it:
|
Which exact version of the Mailer component do they have installed? |
Yes, to replicate you can test with these details (invalid username/password).
This is on v6.4.12 of symfony/mailer |
That is strange. I think we should investigate why there's no warning from PHP. To me, false should be returned only when there's an error. Looks like that's not always the case, but then, what happened? We need to provide the best error message we can. Can we do better than an empty string? That's what I'm wondering. |
According to the documentation
But I wonder how that could happen here as the method should have returned already earlier then because of the |
Closing. Cannot replicate 🤷🏼 |
@bytestream and @nicolas-grekas, I just ran into this error myself, but in the
Obviously I should not be providing a 400 url, but the |
@skylerkatz On which exact version of the Mailer component do you experience the issue? Could this be fixed by #59404? |
I am on |
@skylerkatz I tried to reproduce your issue, but I was not able to do so. My last guess is that you maybe have a custom error handler that influence the result of |
https://www.php.net/manual/en/function.error-get-last.php returns
?array
. Ifnull
is returned, it produces:It's unclear to me how to reproduce the issue. However, it's in our best interests to correctly handle all return types.