Add AhaSend Bridge #58698
Add AhaSend Bridge #58698
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
da486d8 to
27b75ac
Compare
src/Symfony/Bundle/FrameworkBundle/Resources/config/mailer_webhook.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/AhaSend/RemoteEvent/AhaSendPayloadConverter.php
Outdated
Show resolved
Hide resolved
| ]; | ||
| } | ||
|
|
||
| public function testSend() |
There was a problem hiding this comment.
Please use MockHttpClient (no mock) with a JsonMockResponse (also no mock)
There was a problem hiding this comment.
I've made some changes (followed what the Postal mailer bridge is doing). Please let me know if it looks good.
src/Symfony/Component/Mailer/Bridge/AhaSend/Tests/Transport/AhaSendApiTransportTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/AhaSend/Transport/AhaSendApiTransport.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/AhaSend/Transport/AhaSendTransportFactory.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/AhaSend/Webhook/AhaSendRequestParser.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Mailer/Bridge/AhaSend/Webhook/AhaSendRequestParser.php
Outdated
Show resolved
Hide resolved
|
The requested changes have been made, I'd appreciate another review @OskarStark . |
|
Thank you @farhadhf. |
This PR was squashed before being merged into the 7.3 branch. Discussion ---------- [Mailer] Add AhaSend Bridge | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Issues | | License | MIT | Doc PR | symfony/symfony-docs#20361 | Recipe PR | symfony/recipes#1350 This PR adds support for a new mail bridge for the [AhaSend](https://ahasend.com) email service. It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks. Commits ------- 3dfad14 [Mailer] Add AhaSend Bridge
This PR adds support for a new mail bridge for the AhaSend email service.
It includes support for SMTP and API transports (along with support for attachments for the API transport), and both delivery and engagement webhooks.