Skip to content

[HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via php.ini #58704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via php.ini #58704

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48980a2
fix for HttpClientDataCollector fails if proc_open is disabled via ph…
ZaneCEO Oct 29, 2024
e28af34
[HttpClient] Fix Process-based escaping in HttpClientDataCollector
nicolas-grekas Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix for HttpClientDataCollector fails if proc_open is disabled via ph… 
…p.ini . Closes #58700
  • Loading branch information
@ZaneCEO
ZaneCEO authored Oct 29, 2024
commit 48980a2f05a1bb4e9f3d15f8b5979f7ca7185dbc
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ private function escapePayload(string $payload): string
{
static $useProcess;

if ($useProcess ??= class_exists(Process::class)) {
if ($useProcess ??= function_exists('proc_open') && class_exists(Process::class)) {
return (new Process([$payload]))->getCommandLine();
}

Expand Down
Loading