[Config] Handle Phar absolute path in FileLocator
#58713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alexandre-daubois
commented
Oct 30, 2024
•
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Issues | Fix #58708 |
| License | MIT |
8b1d83f to
4f00d6f
Compare
xabbuh
approved these changes
Oct 30, 2024
|
@alexandre-daubois maybe same change should be made in Symfony/Bridge/Twig/Command/DebugCommand.php in isAbsolutePath method |
|
@michalananapps I don't think so, there's no chance to deal with a Phar archive their, isn't it? |
|
Thank you @alexandre-daubois. |
This was referenced Nov 6, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.