[Security] Store original token in token storage when implicitly exiting impersonation #58754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing impersonation
chalasr
approved these changes
Nov 4, 2024
xabbuh
approved these changes
Nov 4, 2024
fabpot
approved these changes
Nov 4, 2024
|
Thank you @wouterj. |
This was referenced Nov 6, 2024
Merged
Merged
Merged
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 19, 2024
…token to vote on (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [Security] use access decision manager to control which token to vote on Following symfony/symfony#58754: calling. `Security::isGranted()` inside a voter has the drawback that we do not know if the checks performed here act on the same token that we have in our voter as the token inside the token storage might have change or may change in between. Commits ------- fc0030a use access decision manager to control which token to vote on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you impersonate user A and then start impersonation for user B, Symfony explicitly exits the first impersonation before starting the second one. However, we did not update the token in the token storage at this moment.
This creates issues when using a custom voter like the one documented, as this uses
Security::isGranted(), which relies on the token in the token storage. So instead of checking if the original user can impersonate, it will check if user A can impersonate.