[Mailer] [Amazon] Add support for custom headers in ses+api #58761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
6f03c14 to
1f82051
Compare
fabpot
requested changes
Nov 27, 2024
src/Symfony/Component/Mailer/Bridge/Amazon/Transport/SesApiAsyncAwsTransport.php
Outdated
Show resolved
Hide resolved
1f82051 to
6038343
Compare
fabpot
approved these changes
Jan 4, 2025
|
Thank you @StudioMaX. |
Spomky
added a commit
to Spomky/symfony
that referenced
this pull request
Feb 26, 2025
Updated the CHANGELOG to reflect the addition of custom headers support in the Amazon SES API mailer. This change will be available starting from version 7.3 instead of 7.2 as per symfony#58761.
Spomky
added a commit
to Spomky/symfony-docs
that referenced
this pull request
Feb 26, 2025
As per symfony/symfony#58761, the warning about requiring the `ses+https` provider for custom headers is no longer relevant and has been removed. Fixes symfony#20512
This was referenced Feb 26, 2025
alexandre-daubois
added a commit
that referenced
this pull request
Feb 27, 2025
…(Spomky) This PR was merged into the 7.3 branch. Discussion ---------- [Mailer] [Amazon] Support for custom headers in ses+api | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Issues | | License | MIT Updated the CHANGELOG to reflect the addition of custom headers support in the Amazon SES API mailer. This change will be available starting from version 7.3 instead of 7.2 as per #58761. Commits ------- be5fb0d [Mailer] [Amazon] Support for custom headers in ses+api
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Feb 27, 2025
This PR was merged into the 7.3 branch. Discussion ---------- [Mailer] [Amazon] Remove outdated warning As per symfony/symfony#58761, the warning about requiring the `ses+https` provider for custom headers is no longer relevant for 7.3 and has been removed. Fixes #20512 Commits ------- f0be895 [Mailer] [Amazon] Remove outdated warning
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until recently it was not possible to add custom headers when using AWS SES API with
Simplemode, see #45168.This problem is also mentioned in Mailer's docs:
However, changes have been made to the SendEmail API and now this will be possible from approximately 2024/03/05.
References:
https://docs.aws.amazon.com/ses/latest/APIReference-V2/API_SendEmail.html
https://awsapichanges.com/archive/changes/539fb6-email.html
In this change I add all custom headers to the request, excluding the standard ones, similar to other transports.
Example: