Skip to content

[Serializer][TypeInfo] fix support for phpstan/phpdoc-parser 2 #58804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2024
Merged

[Serializer][TypeInfo] fix support for phpstan/phpdoc-parser 2 #58804

merged 1 commit into from
Nov 7, 2024
+20 −6

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 7, 2024

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues related to #58796
License MIT

@xabbuh xabbuh requested a review from dunglas as a code owner November 7, 2024 15:25
@carsonbot carsonbot added this to the 7.1 milestone Nov 7, 2024
@xabbuh xabbuh changed the title [Serializer][TypeInfo] run tests also with phpstan/phpdoc-parser 2 [Serializer][TypeInfo] fix support for phpstan/phpdoc-parser 2 Nov 7, 2024
@derrabus
Copy link
Member

derrabus commented Nov 7, 2024

Thank you Christian.

@derrabus derrabus merged commit f0223a2 into symfony:7.1 Nov 7, 2024
9 of 10 checks passed
@derrabus
Copy link
Member

derrabus commented Nov 7, 2024

The changes of #57618 make it a bit difficult to merge this change up. @mtarld Can you help here?

@xabbuh xabbuh deleted the issue-58796-7.1 branch November 7, 2024 16:59
@mtarld
Copy link
Contributor

mtarld commented Nov 7, 2024

Sure @derrabus I'll take care of it 🙂

@mtarld mtarld mentioned this pull request Nov 7, 2024
Closed
@chriskapp chriskapp mentioned this pull request Nov 9, 2024
Closed
@stof stof mentioned this pull request Nov 12, 2024
Closed
@andrew-demb
Copy link
Contributor

andrew-demb commented Nov 12, 2024 •
edited
Loading

@xabbuh can you backport these changes to 6.4 too, please?

UPD: I found #58800, already backported. Thanks!

@stof stof mentioned this pull request Nov 12, 2024
Closed
@theofidry theofidry mentioned this pull request Nov 12, 2024
Merged
This was referenced Nov 13, 2024
Merged
Merged
@Korbeil Korbeil mentioned this pull request Nov 15, 2024
Merged
@renovate renovate bot mentioned this pull request Mar 21, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabus derrabus derrabus approved these changes

@mtarld mtarld mtarld approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Serializer Status: Reviewed TypeInfo
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @derrabus @mtarld @andrew-demb @carsonbot