[PhpUnitBridge] fix dumping tests to skip with data providers #58828

xabbuh · 2024-11-10T21:19:34Z

Q	A
Branch?	5.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Issues
License	MIT

Without the fix running SYMFONY_PHPUNIT_SKIPPED_TESTS='phpunit.skipped' php ./phpunit src/Symfony/Component/Lock/Tests/Store/DoctrineDbalPostgreSqlStoreTest.php without the pdo_pgsql extension enabled the generated skip file looked like this:

<?php return array (
  'PHPUnit\\Framework\\DataProviderTestSuite' =>
  array (
    'Symfony\\Component\\Lock\\Tests\\Store\\DoctrineDbalPostgreSqlStoreTest::testInvalidDriver' => 1,
  ),
  'Symfony\\Component\\Lock\\Tests\\Store\\DoctrineDbalPostgreSqlStoreTest' =>
  array (
    'testSaveAfterConflict' => 1,
    'testWaitAndSaveAfterConflictReleasesLockFromInternalStore' => 1,
    'testWaitAndSaveReadAfterConflictReleasesLockFromInternalStore' => 1,
    'testSave' => 1,
    'testSaveWithDifferentResources' => 1,
    'testSaveWithDifferentKeysOnSameResources' => 1,
    'testSaveTwice' => 1,
    'testDeleteIsolated' => 1,
    'testBlockingLocks' => 1,
    'testSharedLockReadFirst' => 1,
    'testSharedLockWriteFirst' => 1,
    'testSharedLockPromote' => 1,
    'testSharedLockPromoteAllowed' => 1,
    'testSharedLockDemote' => 1,
  ),
);

Thus, running the tests again with the extension enabled would only run 14 tests instead of the expected total number of 16 tests.

With the patch applied the generated skip file looks like this:

<?php return array (
  'Symfony\\Component\\Lock\\Tests\\Store\\DoctrineDbalPostgreSqlStoreTest' =>
  array (
    'testInvalidDriver with data set #0' => 1,
    'testInvalidDriver with data set #1' => 1,
    'testSaveAfterConflict' => 1,
    'testWaitAndSaveAfterConflictReleasesLockFromInternalStore' => 1,
    'testWaitAndSaveReadAfterConflictReleasesLockFromInternalStore' => 1,
    'testSave' => 1,
    'testSaveWithDifferentResources' => 1,
    'testSaveWithDifferentKeysOnSameResources' => 1,
    'testSaveTwice' => 1,
    'testDeleteIsolated' => 1,
    'testBlockingLocks' => 1,
    'testSharedLockReadFirst' => 1,
    'testSharedLockWriteFirst' => 1,
    'testSharedLockPromote' => 1,
    'testSharedLockPromoteAllowed' => 1,
    'testSharedLockDemote' => 1,
  ),
);

Without the fix running `SYMFONY_PHPUNIT_SKIPPED_TESTS='phpunit.skipped' php ./phpunit src/Symfony/Component/Lock/Tests/Store/DoctrineDbalPostgreSqlStoreTest.php` without the pdo_pgsql extension enabled the generated skip file looked like this: ``` <?php return array ( 'PHPUnit\\Framework\\DataProviderTestSuite' => array ( 'Symfony\\Component\\Lock\\Tests\\Store\\DoctrineDbalPostgreSqlStoreTest::testInvalidDriver' => 1, ), 'Symfony\\Component\\Lock\\Tests\\Store\\DoctrineDbalPostgreSqlStoreTest' => array ( 'testSaveAfterConflict' => 1, 'testWaitAndSaveAfterConflictReleasesLockFromInternalStore' => 1, 'testWaitAndSaveReadAfterConflictReleasesLockFromInternalStore' => 1, 'testSave' => 1, 'testSaveWithDifferentResources' => 1, 'testSaveWithDifferentKeysOnSameResources' => 1, 'testSaveTwice' => 1, 'testDeleteIsolated' => 1, 'testBlockingLocks' => 1, 'testSharedLockReadFirst' => 1, 'testSharedLockWriteFirst' => 1, 'testSharedLockPromote' => 1, 'testSharedLockPromoteAllowed' => 1, 'testSharedLockDemote' => 1, ), ); ``` Thus, running the tests again with the extension enabled would only run 14 tests instead of the expected total number of 16 tests. With the patch applied the generated skip file looks like this: ``` <?php return array ( 'Symfony\\Component\\Lock\\Tests\\Store\\DoctrineDbalPostgreSqlStoreTest' => array ( 'testInvalidDriver with data set #0' => 1, 'testInvalidDriver with data set #1' => 1, 'testSaveAfterConflict' => 1, 'testWaitAndSaveAfterConflictReleasesLockFromInternalStore' => 1, 'testWaitAndSaveReadAfterConflictReleasesLockFromInternalStore' => 1, 'testSave' => 1, 'testSaveWithDifferentResources' => 1, 'testSaveWithDifferentKeysOnSameResources' => 1, 'testSaveTwice' => 1, 'testDeleteIsolated' => 1, 'testBlockingLocks' => 1, 'testSharedLockReadFirst' => 1, 'testSharedLockWriteFirst' => 1, 'testSharedLockPromote' => 1, 'testSharedLockPromoteAllowed' => 1, 'testSharedLockDemote' => 1, ), ); ```

alexandre-daubois · 2024-11-12T12:44:16Z

Is Psalm feedback relevant? I'm not sure, is getName() available in all supported PHPUnit versions?

xabbuh · 2024-11-12T12:56:28Z

That’s not relevant as the listener is not usable with PHPUnit 10+ anyway.

stof · 2024-11-12T14:56:54Z

However, we might need a similar fix in the new implementation supporting PHPUnit 11 in the 7.2 branch (unless that new implementation was not impacted by the bug)

xabbuh · 2024-11-12T14:59:33Z

We in fact need to re-implement this feature for the new event system in PHPUnit 11 (the failures related to this being missing) made me aware of the fact that we didn't port this feature yet.

nicolas-grekas · 2024-11-13T14:10:07Z

Thank you @xabbuh.

carsonbot added Status: Needs Review Bug PhpUnitBridge labels Nov 10, 2024

carsonbot added this to the 5.4 milestone Nov 10, 2024

carsonbot changed the title ~~[PhpUnitBridge] fix dumping tests to skip with data providers~~ [PhpUnitBridge] fix dumping tests to skip with data providers Nov 10, 2024

alexandre-daubois approved these changes Nov 12, 2024

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels Nov 12, 2024

nicolas-grekas merged commit 31bd807 into symfony:5.4 Nov 13, 2024
12 of 13 checks passed

xabbuh deleted the phpunit-bridge-skip-file-data-providers branch November 13, 2024 14:10

This was referenced Nov 27, 2024

Release v5.4.48 #59016

Merged

Release v6.4.16 #59017

Merged

Release v7.1.9 #59018

Closed

Release v7.1.9 #59019

Merged

Release v7.2.0 #59032

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PhpUnitBridge] fix dumping tests to skip with data providers #58828

[PhpUnitBridge] fix dumping tests to skip with data providers #58828

xabbuh commented Nov 10, 2024

alexandre-daubois commented Nov 12, 2024

xabbuh commented Nov 12, 2024

stof commented Nov 12, 2024

xabbuh commented Nov 12, 2024

nicolas-grekas commented Nov 13, 2024

[PhpUnitBridge] fix dumping tests to skip with data providers #58828

[PhpUnitBridge] fix dumping tests to skip with data providers #58828

Conversation

xabbuh commented Nov 10, 2024

alexandre-daubois commented Nov 12, 2024

xabbuh commented Nov 12, 2024

stof commented Nov 12, 2024

xabbuh commented Nov 12, 2024

nicolas-grekas commented Nov 13, 2024