[AssetMapper] ignore missing directory in isVendor()
#58859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40ac31b to
d38fc98
Compare
isVendor()
isVendor()isVendor()
74495f5 to
88ab9b0
Compare
|
Arf sorry.... i did not see it :( |
chalasr
approved these changes
Nov 14, 2024
isVendor()isVendor()
Your PR relies on a simple mock, while my PR changes |
isVendor()isVendor()
No idea 🤷 But if you want to take anything from my closed PR you can of course :) |
Thanks for the feedback, let's see the opinions of the reviewers. 🙂 |
88ab9b0 to
9e3984f
Compare
|
Thank you @alexislefebvre. |
|
Less mocks FTW |
Merged
This was referenced Nov 27, 2024
Closed
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Jan 7, 2025
…lexislefebvre) This PR was merged into the 7.3 branch. Discussion ---------- [AssetMapper] use constants in MappedAssetFactoryTest | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | no | License | MIT This avoids repeating `__DIR__` in several places. Follow-up of: - #58859 Commits ------- cdb3080 feat: use constants in MappedAssetFactoryTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how to add tests yet, because this method is private.