[DomCrawler/CssSelector] Fixed namespace using in filter by xpath #5886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -502,6 +503,9 @@ public function filterXPath($xpath) | |||
| } | |||
|
|
|||
| $domxpath = new \DOMXPath($document); | |||
| foreach($namespaces as $prefix=>$uri) { | |||
There was a problem hiding this comment.
please add space around =>
|
it is not clear that the new parameter must be an associated array with prefix => uri, could you document it somewhere ? phpdoc, doc ? |
|
Sorry, closed it by mistake. Reopen it again. More detailed comment for $namespaces param is added and code style is fixed |
|
It would be great if this feature is implemented in the DomCrawler component 👍 |
| @@ -502,6 +503,9 @@ public function filterXPath($xpath) | |||
| } | |||
|
|
|||
| $domxpath = new \DOMXPath($document); | |||
| foreach($namespaces as $prefix => $uri) { | |||
There was a problem hiding this comment.
there is a missing space after foreach.
|
@fabpot Isn't this BC break? (adds new argument to method marked with |
|
@fabpot @tereschenkov I could work on namespace autodetection. |
| } | ||
|
|
||
| /** | ||
| * @expectedException \PHPUnit_Framework_Error_Warning |
There was a problem hiding this comment.
This is not appropriate exception we should expect here.
|
Closing in favor of #6650 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes: #4845