[Form] BirthdayType has automatic attr when widget is single_text
#58871
+42
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
reviewed
Nov 14, 2024
src/Symfony/Component/Form/Extension/Core/Type/BirthdayType.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/Type/BirthdayType.php
Outdated
Show resolved
Hide resolved
32af7d0 to
60c6ed9
Compare
60c6ed9 to
ef80577
Compare
|
by "user timezone", you mean the timezone that the browser is using when performing the client-side validation ? There is no way to get it as it is something that is not sent to the server. |
|
btw, a date does not have a timezone |
stof
reviewed
Nov 14, 2024
src/Symfony/Component/Form/Extension/Core/Type/BirthdayType.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Extension/Core/Type/BirthdayType.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Form/Tests/Extension/Core/Type/BirthdayTypeTest.php
Outdated
Show resolved
Hide resolved
BirthdayType has automatic attr when widget is single_text
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I change the logic to @stof advises. So I change the vars in the form view with the
buildViewfunction instead of usingconfigureOptionsfunction.I feel that I am doing something wrong since the default value of attr['min'] and attr['max'] are defined with
date()function (+ years provided in the options). Final user day can be another one because of his timezone. Is it possible to get the user timezone from there ? Or it's not a big matter ?