add comment explaining why HttpClient tests are run separately #58951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterj
approved these changes
Nov 20, 2024
alexandre-daubois
approved these changes
Nov 20, 2024
.github/workflows/windows.yml
Outdated
| @@ -110,6 +110,8 @@ jobs: | |||
| Remove-Item -Path src\Symfony\Bridge\PhpUnit -Recurse | |||
| mv src\Symfony\Component\HttpClient\phpunit.xml.dist src\Symfony\Component\HttpClient\phpunit.xml | |||
| php phpunit src\Symfony --exclude-group tty,benchmark,intl-data,network,transient-on-windows || ($x = 1) | |||
| # HttpClient tests need to run separately, they block when run with other components' tests concurrently | |||
| # see https://github.com/symfony/symfony/pull/35115 and https://github.com/symfony/symfony/pull/58916 | |||
There was a problem hiding this comment.
I'd rather remove any ref to github, git blame is enough as a link
5f1173a to
cbdb08a
Compare
|
Thank you @xabbuh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #35115 and #58916