[DoctrineBridge] Fix Connection::createSchemaManager() for Doctrine DBAL v2
#58956
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for bug fixes". Cheers! Carsonbot |
|
Can we cover this with a test to prevent regressions? |
|
I guess I can ! |
Connection::createSchemaManager() for Doctrine DBAL v2
src/Symfony/Bridge/Doctrine/SchemaListener/AbstractSchemaListener.php
Outdated
Show resolved
Hide resolved
…BAL v2 As the 6.4 symfony/doctrine-bridge is compatible with doctrine/dbal 2.13 we need to check for createSchemaManager existance and use getSchemaManager instead if necessary (like it's already done in the messenger component for instance)
|
Thank you @neodevcode. |
As the 6.4 symfony/doctrine-bridge is compatible with doctrine/dbal 2.13 we need to check for createSchemaManager existance and use getSchemaManager instead if necessary (like it's already done in the messenger component for instance)