Skip to content

[Messenger] fix Envelope::all() conditional return docblock #58977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 26, 2024
Merged

[Messenger] fix Envelope::all() conditional return docblock #58977

merged 1 commit into from
Nov 26, 2024

Conversation

kbond
Copy link
Member

@kbond kbond commented Nov 25, 2024 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues n/a
License MIT

I think this was a typo in #47016.

@carsonbot carsonbot added this to the 6.4 milestone Nov 25, 2024
@kbond kbond requested a review from wouterj November 25, 2024 02:05
@kbond
Copy link
Member Author

kbond commented Nov 25, 2024

@wouterj, sorry, I'm not familiar at all with psalm. I'm not sure how to fix the errors or what I did wrong.

@wouterj
Copy link
Member

wouterj commented Nov 25, 2024

@wouterj, sorry, I'm not familiar at all with psalm. I'm not sure how to fix the errors or what I did wrong.

I believe Psalm complains because we don't document anywhere that everything under $this->stamps[SomeStamp::class] is instance of SomeStamp. I've asked on Slack if someone has a way to do this, but I think we can ignore this error. The user will not receive this error.

@kbond
Copy link
Member Author

kbond commented Nov 25, 2024

Ok, how can I suppress the error here?

@stof
Copy link
Member

stof commented Nov 25, 2024

@kbond you can ignore it for now.

Our usage of Psalm is a bit special as each PR reports only new failure (it generates a baseline for the existing state of the target branch before analyzing the code of the PR)

@nicolas-grekas
Copy link
Member

Thank you @kbond.

@nicolas-grekas nicolas-grekas merged commit a59ff05 into symfony:6.4 Nov 26, 2024
4 of 10 checks passed
@kbond kbond deleted the fix/messenger-envelope-docblock-fix branch November 26, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

@wouterj wouterj Awaiting requested review from wouterj

Assignees
No one assigned
Labels
Messenger Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
6 participants
@kbond @wouterj @stof @nicolas-grekas @chalasr @carsonbot