Skip to content

[PropertyInfo] remove conflict with symfony/serializer < 6.4 #59008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 27, 2024

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit eec07d9 into symfony:6.4 Nov 27, 2024
10 checks passed
@stof
Copy link
Member

stof commented Nov 27, 2024

is symfony/serializer 6.3 actually compatible with property-info 6.4 ? We might have added this conflict for a reason.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 27, 2024

I think the reason was being overzealous. I tried locally, seems to work. Lets see the CI.

@xabbuh xabbuh deleted the pr-58997 branch November 27, 2024 09:53
@stof
Copy link
Member

stof commented Nov 27, 2024

Well, as you haven't change the dev requirement, the CI will still not try to use older versions.

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Nov 27, 2024

That's not the point: the point is to allow Serializer 5.4 to use PropertyInfo 6.4, which does work (verified by the CI).
That's what I mean by being overzealous: the conflict was added in good faith to match what require-dev says, but this is actually too restrictive, and excludes newer versions for no valid reasons for users of older stacks.

@xabbuh
Copy link
Member Author

xabbuh commented Nov 28, 2024

@stof not updating the constraint in require-dev was a mistake, #59010 fixed that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants